#880 – Can not upload photos on group walls and discussions

Hi

This is a known issue in Jomsocial, which doesn't comply with Joomla 3 API (at least it was reported for videos, and we debugged Jomsocial to check it was indeed the same problem as before). It's the same issue you faced in ticket 480.
1 - Normally you should have enabled this workaround from ticket 480. Is it not enabled?

2 - Which version of sh404SEF and most importantly Jomsocial are you using? One of our user with the same problem (who applied the workaround and so was fine), told us that they just had a release fixing this problem?

Rgds

Hi

After long efforts from DImitris and I, we manage to find the fix in Jomsocial. It was clear from the start that the problem was there, because we could see JS was not using correct URLs, but we felt we had to provide the fix so that the problem is clear for everyone.

Yes, before youask: the problem is in Jomsocial even if it "works" when sh404SEF is disabled. There are incorrectly using relative urls, which is forbidden when using SEF URLs. It only happens that the Joomla router doesn't fire a 404 immediately when it sees that and so the error doesn't become visible when only Joomla SEF is used.

In addition, this is not the first time this problem happens with Jomsocial, we had that also 3-4 years back, and they fixed it.

I can provide you with a fix as follow:
- opent the file /components/com_community/assets/release_32/js/bundle.js
- do a search to find the string:

var b="index.php?option=com_community&view=photos&task=ajaxPreview"

- replace it with:

var b=joms.BASE_URL + "index.php?option=com_community&view=photos&task=ajaxPreview"

- save the file
- clear your browser cache and try uploading an image.

I also have to say that there are other places where they have the same problem (using a relative URL), so you might be in for other surprises.

Tomorrow, we'll contact them and hopefully they can fix this problem in an upcoming release.

Rgds

Hi

Yes, in debugging, we've found that this issue appears in multiple locations, so I'm not surprised it happens elsewhere.
We haven't contacted Jomsocial yet. Have you tried?

Rgds

Even if you quoted my reply above, explaining the bug and the solution?

Sorry about that, I will have to make contact with their manager, but what a pain.

Rgds

Hi

I wish you could release a new version that works with jomsocial.

In case you didn't notice, there is absolutely NOTHING we can do.

This is a simple bug in Jomsocial, which cals bad URLs when doing javascript calls.

The URL called is also wrong when using only Joomla SEF. It should also trigger a 404 with Joomla SEF, but unfortunately, Joomla router is not firing 404 when it should and let this go.
sh404SEF is an SEO-based extension and I will never let this go through. For your own good.

Again, this is not the first time it happens with Jomsocial, and once again they'll fix it, but in the mean time, it's us being considered the problematic guys.

[EDIT] Regarding your conversation with them, you didn't quote the most crucial part,the explanation:

Yes, before youask: the problem is in Jomsocial even if it "works" when sh404SEF is disabled. There are incorrectly using relative urls, which is forbidden when using SEF URLs. It only happens that the Joomla router doesn't fire a 404 immediately when it sees that and so the error doesn't become visible when only Joomla SEF is used.

Regardless, I don't think a support guy in a large company like Jomsocial will listen to that. I'll make contact with the company owner ASAP.

Rgds

Hi

Can you provide a link to that support thread please.

Rgds

Hi

I have emailed the owner, asking for a contact person in charge.

Rgds

Thanks.

I also contacted here on Facebook, should be quicker than through email.

Rgds

Hi

Got a reply from the owner this night, and she sent me to the project manager. I emailed him minutes ago:

Hi Sinisa,



I am Yannick, I develop sh404SEF. Merav asked that I contacted you regarding an issue we uncovered on one of our customers site, using Jomsocial 4.0.9.



The issue first appeared when a user tries to upload a photo to a group wall. The uploader would be stuck, the photo preview never showing and the photo never uploaded.



The issue would appear only when sh404SEF was enabled, and so the customer was thinking that it was caused by sh404SEF. Jomsocial support also very immediately said that it was sh404SEF fault.



After much digging in your javascript, the problem found is actually a very common one. You're using relative URLs to fetch content from the site.



For example, in the group wall photo uploaders, the javascript in bundle.js makes a request to:



index.php?option=com_community&view=photos&task=ajaxPreview&no_html=1&tmpl=component&groupid=20



instead of prefixing the URL with JURI::base().



The resulting URL fetched by the browser is therefore:



/sandbox/t880/Business/america/index.php?option=com_community&view=photos&task=ajaxPreview&no_html=1&tmpl=component&groupid=20



With Joomla router, which does not behaves properly according to SEO standard, this URL is ok and you can get your content. With a SEO oriented extension such as sh404SEF, of course we cannot accept this invalid URL and fire a 404.



After much more digging, we found the following fix:

- in /components/com_community/assets/release_32/js/bundle.js, replace:



var b="index.php?option=com_community&view=photos&task=ajaxPreview"



with



var b=joms.BASE_URL + "index.php?option=com_community&view=photos&task=ajaxPreview"



This fixes the problem for the group wall uploader, but the customer reported it happens in other locations, like a user uploading a photo to their wall.



Merav mentioned an issue you have already solved (https://github.com/jomsocial/JomSocial/issues/457) but I can't access it, so I won't know if it's already solved.



Please review your javascript to be sure only absolute URLs are used whenever you fetch some content from javascript.



I look forward to hearing from you quickly.



Rgds



Yannick Gaultier



@weeblr

https://weeblr.com

Here is the reply:
[quote]Sinisa (JomSocial)

10:06 (Il y a 15 minutes)

À moi
Hello Yannick

This morning i found that report in our bug tracker. I can confirm the issue has been fixed internally and will be included in next release.

Regards,
_____
Siniša Krišan
JomSocial Project Manager
www.jomsocial.com
Phone (Serbia): xxxx
Phone (Indonesia): xxxx
Skype: xxxx
Twitter: xxxx

Rgds

Hi

I think it's pretty obvious that we are already so much far beyond what we should be doing in terms of support. We don't want to spend more time on stuff that's not sh404SEF related on your site.
Please just think that we had to spend more than 8 hours of debugging and research work just to prove something we knew from the first minute - that it was a bug in Jomsocial.

It's a shame they just don't take responsibility for that and it's even worse because they replied on their support thread with you that sh404SEF was the cause of the problem, while the bug was known and already fixed. So you wasted your time and we wasted our time.

Rgds