• Home
  • Get help
  • Ask a question
Last post 6 hours 58 min ago
Posts last week 94
Average response time last week 34 min
All time posts 67914
All time tickets 10497
All time avg. posts per day 20

Helpdesk is open from Monday through Friday CET

Please create an (free) account to post any question in the support area.
Please check the development versions area. Look at the changelog, maybe your specific problem has been resolved already!
All tickets are private and they cannot be viewed by anyone. We have made public only a few tickets that we found helpful, after removing private information from them.

#897 – Fix in code for improve component

Posted in ‘sh404SEF’
This is a public ticket. Everybody will be able to see its contents. Do not include usernames, passwords or any other sensitive information.
Monday, 24 August 2015 11:13 UTC
redcomponent
 Hello. I find one function which can be ipmprove, please add this changes in the next release, because in my project it function adds around 0.8-1sec page loads(Generates around 700 links per page).
File: administrator/components/sh404sef/helper/updates.php
String: 86
Text: $response = $cache->call(array('Sh404sefHelperUpdates', '_doRemoteConfig'));
Need change to:
static $response = false;
if ($response === false)
{
$response = $cache->call(array('Sh404sefHelperUpdates', '_doRemoteConfig'));
}
Joomla cache calls not a fast and for big count links added bid time loads.
Thanks.
Monday, 24 August 2015 11:16 UTC
wb_weeblr
Hi

Thanks, that's an interestnig improvement, though I'm surprised it makes such a difference. Of course, with 700 links on page, everything makes a difference...

Rgds
 
Monday, 24 August 2015 11:29 UTC
redcomponent
Another one time delay in the current joomla release file
https://github.com/joomla/joomla-cms/blob/master/libraries/vendor/joomla/string/src/String.php#L620
You use JString class many times, which call very slow 'require_once'.

In the next release it must be fix https://github.com/joomla/joomla-cms/blob/3.5-dev/libraries/vendor/joomla/string/src/StringHelper.php#L644-L647

So you component must be more improve too :)
Monday, 24 August 2015 11:30 UTC
wb_weeblr
Cool. Indeed, we must now use JString a lot, as URL can have UTF-8 characters.

Thanks for your input. I haven't run profiling on sh404SEF in a while, and there are things to improve for sure, especially on large sites, or rather sites with many links on a page.

Rgds
 
This ticket is closed, therefore read-only. You can no longer reply to it. If you need to provide more information, please open a new ticket and mention this ticket's number.