#1597 – 404 Error Page not displaying (sometimes)

Hi

Please note that the error page from sh404SEF seems to work fine in both cases.

http://www.xxxx.fr/presentation/wrong/path working means that Joomla is selecting an Itemid to display the error page (probably because "presentation" is matching one of your menu items)

http://www.xxxx.fr/wrong/path "not working" means Joomla doesn't find an Iitemid and so it defaults to using the home page template and modules, and your template probably removes the main "component" area on the home page.

Most likely, what you need to do is select an Itemid to display the error page, under the corresponding sh404SEF "Error page" tab of configuration.

Rgds

Hi

OK, so your template is probably messing up more than that. Could you please provide us with superadmin credentials to your website. You can create a temporary account, and delete it afterwards, but it must have superuser level.

Thanks and regards

Hi

sh404SEF version 4.6.0???? please update.

You also had 2 languages published for your content (under the "Content" tab of Joomla language manager), which fools sh404SEF or other extensions thinking the site is multilingual. I disabled English just in case.

Rgds

Hi

So this is your template causing this, all is fine with Joomla default templates. I'll try playing a bit with the templates settings, they very unfortunately tend to try do everything and the rest these days....
Rgds

Hi

Actually, after much digging, downloading a backup and debugging step by step, I found it's not the template. It's JFBConnect causing this (though I don't blame them entirely, the Joomla router is not doing a proper job there).

The full story is this:

- JFB has an OpenGraph plugin. This plugin is fired when the document is rendered, probably to insert OpenGraph meta data
- on line 214 of the file /components/com_jfbconnect/models/opengraphaction.php, they do:

$queryVars = $router->parse($juri);

This causes the Joomla router to reset the Itemid. So instead of using our 404 error page Itemid, JFBConnect causes the Itemid to be reset to the home page, and the content is not displayed.

This can be fixed by replacing the above code with, for instance:

$queryVars = JFactory::getApplication()->input->get->getArray();

which is the correct way according to Joomla API.

I wish I was not the one having to spend hours on debugging other people code :(

Rgds

Hi

Please note this is NOT a compatibility issue with sh404SEF (contrary to your thread title there). It's a pure bug, they just should use the Joomla API.

Also, while debugging, I noticed that the mod_easysocial_login module is using pretty much the same code; it's not causing issues right now, due to the fact that modules are processed differently by Joomla, but it's a pretty common problem.

Rgds

Hi

I understand that, but in the end, because sh404SEF Is right in the middle of this, and "problem only appear when sh404SEF is enabled", publicly it always end up being sh404SEF fault.

When people start to understand that because the problem occurs when you enable sh404SEF doesn't mean at all that sh404SEF causes it, I will have made huge progress!

Rgds

Hi

Indeed, here is what can be said. Please post this, and then suggest they contact me directly after that. But please post this publicly, as otherwise their version will be the public one:

It seems like sh404SEF is overriding the core-Joomla router, but not doing a full implementation.

nope, we do NOT override the core router. We follow Joomla API and only set up buildRules and parseRules.

However, we do a lot of work to get the information about the current route first and then we use the setVars() function to reset the router back to its previous state. sh404SEF's router seems to ignore the setVars call.

We do not ignore it. As per the above, you are actually calling Joomla original setVars() function, in Joomla router. This method is not modified or altered in any way by sh404SEF.

The problem is that calling setVars is NOT enough. It does reset (some) of the router state, but the router is unfortunately not "self-contained".When you do that, you only reset the router internal storage of variables, but you basically don't do anything else.
The problem is that the parse() method has side effects, external to the router itself:

$queryVars = $router->parse($juri);

This code actually reset the active menu in the Joomla menu object. In other words, you reset the current active menu globally for the whole app. Yes, Joomla should not to do that probably, but that's how it works. It's done in JRouterSite, in various locations:

if (isset($vars['Itemid']))
{
$this->menu->setActive($vars['Itemid']);
}

From reading your code, I understand the only you need is the current page query vars, which can be obtained safely through the Joomla API using:

$queryVars = JFactory::getApplication()->input->get->getArray();

I'm not sure what problem this very safe, read only method is causing to you. But I have spent quite some times stepping through the PHP code to be sure changing the currently active menu is causing the problem here.
As an alternate solution, maybe you could keep your current code, but in addition also reset the Itemid?

$router->setVars($origVars);
if(!empty($origVars['Itemid'])
{
JFactory::getApplication()->getMenu()->setActive($origVars['Itemid']);
}


Rgds

Hi

Sure, they can talk to me at [email protected]

Regards

Hi

I still have an empty 404 error page. Would you please test it?

I'm sorry but this thread is entirely and totally solved for us. We spent several hours debugging another extension bugs, we found the bug, we provided a working solution to a bug in another extension. There are limits to being nice and fixing other people problems.

Rgds

Hi

But the last code change you suggested does not seem to work.

It was working very well for me, on the backup of your site I downloaded and used to debug.

I am talking about this, which is the only solution that complies with Joomla API:

$queryVars = JFactory::getApplication()->input->get->getArray();

Rgds